From 1380b802dce45956df02de8c088dc20b81959be6 Mon Sep 17 00:00:00 2001
From: Brendan Hansen <brendan.f.hansen@gmail.com>
Date: Thu, 17 Dec 2020 16:02:08 -0600
Subject: [PATCH] added test case for array/struct robustness; small bugfix

---
 onyx                               | Bin 516732 -> 516732 bytes
 src/onyxwasm.c                     |   4 +-
 tests/array_struct_robustness      |  15 +++++
 tests/array_struct_robustness.onyx |  98 +++++++++++++++++++++++++++++
 4 files changed, 115 insertions(+), 2 deletions(-)
 create mode 100644 tests/array_struct_robustness
 create mode 100644 tests/array_struct_robustness.onyx

diff --git a/onyx b/onyx
index adabd591f2cd54e4de49bf3bd92029a5c46ff051..7e4f8e784411ae235b607d6681ccdd2a0420641a 100755
GIT binary patch
delta 154
zcmV;L0A>ID#2@^`AAp1bv;rOb0l2pw`vQLh0l2rG{sK-40a&-~2m_wh0R*><-vb~&
z0k?;(9t5|o9tEjz0a>?Kj|EH`0mZkZsRe}u0qD0Xt_3Io0rQtruLbY{1-C@71y%|H
zI+vTe1z-U@xBR*Vn;HSBx0uxhV=@7SxBLeNB{c!=mm)m|(gF6j^*shG5&=htB2Wgm
IB2WiflC-uu>;M1&

delta 154
zcmV;L0A>ID#2@^`AAp1bv;rOb0l>E&`vQLh0l>GO{sK-40aUl`2m_wh0RXp*-vb~&
z0kem#9t5|o9tEjz0adqGj|EH`0l~MVsRe}u0pzzTt_3Io0q>VnuLbY{0k=f31y%|H
zHkX^a1z-U<xBR*Vn;HS7x0uxhV=@7OxBLeNB{c!+mm)m|(gE_f^*shG5&=VpB2Wgm
IB2WiflC8!%zyJUM

diff --git a/src/onyxwasm.c b/src/onyxwasm.c
index 93528191..357fa062 100644
--- a/src/onyxwasm.c
+++ b/src/onyxwasm.c
@@ -519,7 +519,7 @@ EMIT_FUNC(assignment, AstBinaryOp* assign) {
         // greater than like 16 we output a loop that copies them?
         //                                               - brendanfh 2020/12/16
         fori (i, 0, elem_count) {
-            if (!type_is_structlike(rtype))
+            if (!type_is_structlike(elem_type))
                 WIL(WI_LOCAL_GET, lptr_local);
 
             if (bh_arr_last(code).type == WI_LOCAL_SET && bh_arr_last(code).data.l == rptr_local)
@@ -528,7 +528,7 @@ EMIT_FUNC(assignment, AstBinaryOp* assign) {
                 WIL(WI_LOCAL_GET, rptr_local);
             emit_load_instruction(mod, &code, elem_type, i * elem_size);
 
-            if (!type_is_structlike(rtype)) {
+            if (!type_is_structlike(elem_type)) {
                 emit_store_instruction(mod, &code, elem_type, i * elem_size);
             } else {
                 WIL(WI_LOCAL_GET, lptr_local);
diff --git a/tests/array_struct_robustness b/tests/array_struct_robustness
new file mode 100644
index 00000000..038649df
--- /dev/null
+++ b/tests/array_struct_robustness
@@ -0,0 +1,15 @@
+Array of structs on the stack.
+Vec2(4039, 7782)
+Array of structs from function call.
+Vec2(0, 0)
+Vec2(1, 1)
+Vec2(4, 8)
+Vec2(9, 27)
+Array of structs on a struct.
+Vec2(3, 9)
+Vec2(3, 27)
+Array of structs on a struct from function call.
+Vec2(25, 125)
+Vec2(100, 1000)
+Array of u32.
+63001
diff --git a/tests/array_struct_robustness.onyx b/tests/array_struct_robustness.onyx
new file mode 100644
index 00000000..1c12ce4e
--- /dev/null
+++ b/tests/array_struct_robustness.onyx
@@ -0,0 +1,98 @@
+#include_file "core/std/js"
+
+use package core
+
+Vec2 :: struct { x: i32; y: i32; }
+
+// Overload print() to print Vec2's.
+proc (use v: Vec2) #add_overload print {
+    printf("Vec2(%i, %i)", x, y);
+}
+
+EntityStore :: struct {
+    positions  : [4] Vec2;
+    velocities : [4] Vec2;
+}
+
+calc_vecs :: proc (n := 0) -> [4] Vec2 {
+    vecs : [4] Vec2;
+
+    i := n;
+    for ^v: vecs {
+        v.x = i * i;
+        v.y = i * i * i;
+        i += 1;
+    }
+
+    return vecs;
+}
+
+main :: proc (args: [] cstr) #export "MAIN" {
+    // Array of structs on stack
+    {
+        println("Array of structs on the stack.");
+        vecs : [8] Vec2;
+        for ^v: vecs {
+            v.x = 4039;
+            v.y = 7782;
+        }
+        
+        println(vecs[3]);
+    }
+
+    // Array of structs from function call
+    {
+        println("Array of structs from function call.");
+        vecs := calc_vecs();
+        for ^v: vecs do println(*v);
+    }
+
+    // Array of structs on a struct
+    {
+        println("Array of structs on a struct.");
+
+        es : EntityStore;
+        es.positions = Vec2.[
+            Vec2.{ 0, 0 },
+            Vec2.{ 1, 1 },
+            Vec2.{ 2, 4 },
+            Vec2.{ 3, 9 },
+        ];
+
+        es.velocities = Vec2.[
+            Vec2.{ 0, 0 },
+            Vec2.{ 1, 1 },
+            Vec2.{ 2, 8 },
+            Vec2.{ 3, 27 },
+        ];
+
+        println(es.positions[3]);
+        println(es.velocities[3]);
+    }
+
+    // Array of structs on a struct from function call
+    {
+        println("Array of structs on a struct from function call.");
+
+        es : EntityStore;
+        es.positions = calc_vecs(5);
+        es.velocities = calc_vecs(10);
+
+        println(es.positions[0]);
+        println(es.velocities[0]);
+    }
+
+    // Array of u32
+    {
+        println("Array of u32.");
+
+        nums : [100] u32;
+        i := 1;
+        for ^n: nums {
+            *n = i * i;
+            i += 5;
+        }
+
+        println(nums[50]);
+    }
+}
\ No newline at end of file
-- 
2.25.1