From: Brendan Hansen <brendan.f.hansen@gmail.com>
Date: Tue, 30 Nov 2021 01:02:46 +0000 (-0600)
Subject: cleanup
X-Git-Url: https://git.brendanfh.com/?a=commitdiff_plain;h=a04b4a48daaed84816d3d6bef7b377a9a498aae0;p=onyx.git

cleanup
---

diff --git a/src/checker.c b/src/checker.c
index 973f435a..7b6df3f3 100644
--- a/src/checker.c
+++ b/src/checker.c
@@ -285,11 +285,8 @@ CheckStatus check_for(AstFor* fornode) {
     if (fornode->by_pointer)
         fornode->var->flags |= Ast_Flag_Cannot_Take_Addr;
 
-    if (fornode->loop_type == For_Loop_Invalid) {
-        ERROR_(error_loc,
-                "Cannot iterate over a '%s'.",
-                type_get_name(iter_type));
-    }
+    if (fornode->loop_type == For_Loop_Invalid)
+        ERROR_(error_loc, "Cannot iterate over a '%s'.", type_get_name(iter_type));
 
     CHECK(block, fornode->stmt);
 
@@ -1314,10 +1311,7 @@ CheckStatus check_do_block(AstDoBlock** pdoblock) {
     doblock->block->rules = Block_Rule_Do_Block;
     CHECK(block, doblock->block);
 
-    if (doblock->type == &type_auto_return) {
-        // ERROR(doblock->token->pos, "Unable to determine type of do-block expression.");
-        doblock->type = &basic_types[Basic_Kind_Void];
-    }
+    if (doblock->type == &type_auto_return) doblock->type = &basic_types[Basic_Kind_Void];
 
     expected_return_type = old_expected_return_type;
     doblock->flags |= Ast_Flag_Has_Been_Checked;
@@ -2633,21 +2627,6 @@ poly_query_done:
     return Check_Complete;
 }
 
-CheckStatus check_node(AstNode* node) {
-    switch (node->kind) {
-        case Ast_Kind_Function:             return check_function((AstFunction *) node);
-        case Ast_Kind_Overloaded_Function:  return check_overloaded_function((AstOverloadedFunction *) node);
-        case Ast_Kind_Block:                return check_block((AstBlock *) node);
-        case Ast_Kind_Return:               return check_return((AstReturn *) node);
-        case Ast_Kind_If:                   return check_if((AstIfWhile *) node);
-        case Ast_Kind_Static_If:            return check_if((AstIfWhile *) node);
-        case Ast_Kind_While:                return check_while((AstIfWhile *) node);
-        case Ast_Kind_Call:                 return check_call((AstCall **) &node);
-        case Ast_Kind_Binary_Op:            return check_binaryop((AstBinaryOp **) &node);
-        default:                            return check_expression((AstTyped **) &node);
-    }
-}
-
 void check_entity(Entity* ent) {
     CheckStatus cs = Check_Success;
 
@@ -2665,16 +2644,14 @@ void check_entity(Entity* ent) {
         case Entity_Type_Macro:                    cs = check_macro(ent->macro); break;
         case Entity_Type_Constraint_Check:         cs = check_constraint(ent->constraint); break;
         case Entity_Type_Polymorph_Query:          cs = check_polyquery(ent->poly_query); break;
+        case Entity_Type_Enum_Value:               cs = check_expression(&ent->enum_value->value); break;
+        case Entity_Type_Process_Directive:        cs = check_process_directive((AstNode *) ent->expr); break;
 
         case Entity_Type_Expression:
             cs = check_expression(&ent->expr);
             resolve_expression_type(ent->expr);
             break;
 
-        case Entity_Type_Enum_Value:
-            cs = check_expression(&ent->enum_value->value);
-            break;
-
         case Entity_Type_Type_Alias:
             if (ent->type_alias->kind == Ast_Kind_Struct_Type)
                 cs = check_struct((AstStructType *) ent->type_alias);
@@ -2682,8 +2659,6 @@ void check_entity(Entity* ent) {
                 cs = check_type(ent->type_alias);
             break;
 
-        case Entity_Type_Process_Directive:        cs = check_process_directive((AstNode *) ent->expr); break;
-
         case Entity_Type_File_Contents: 
             if (context.options->no_file_contents) {
                 onyx_report_error(ent->expr->token->pos, "#file_contents is disabled for this compilation.");