From: Brendan Hansen <brendan.f.hansen@gmail.com>
Date: Thu, 8 Apr 2021 17:58:11 +0000 (-0500)
Subject: updated windows-build.yml
X-Git-Url: https://git.brendanfh.com/?a=commitdiff_plain;h=8d452623babf9c57d4abc0c2b472b968133d15f7;p=onyx.git

updated windows-build.yml
---

diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml
index 206d4ec7..eb476574 100644
--- a/.github/workflows/windows-build.yml
+++ b/.github/workflows/windows-build.yml
@@ -31,3 +31,9 @@ jobs:
       # Runs a single command using the runners shell
       - name: Build a release build
         run: cmd.exe /c 'build.bat 1'
+
+      - name: Upload executable file
+        uses: actions/upload-artifact@v2
+        with:
+          name: executable
+          path: onyx.exe
diff --git a/core/stdio.onyx b/core/stdio.onyx
index 81a98369..86569be3 100644
--- a/core/stdio.onyx
+++ b/core/stdio.onyx
@@ -7,9 +7,6 @@ package core
 // in anyway.
 
 
-// It is expected that a file will be included that will be part
-// of the system package
-
 use package runtime as runtime
 #if runtime.Runtime == runtime.Runtime_Custom {
     #error "'stdio' can only be included in the 'wasi' or 'js' runtime."
diff --git a/examples/05_slices.onyx b/examples/05_slices.onyx
index bc2649cd..d9046a39 100644
--- a/examples/05_slices.onyx
+++ b/examples/05_slices.onyx
@@ -26,7 +26,7 @@ main :: (args: [] cstr) {
     for elem: slice do printf("%i ", elem);
     print("\n");
 
-    // Another equivalent way of writing lines 21 and 22 is to
+    // Another equivalent way of writing lines 22 and 23 is to
     // use the array subscript notation, but provide a range for
     // the index as so. This is generally called the slice literal
     // notation.
diff --git a/src/onyxutils.c b/src/onyxutils.c
index 91de1ac0..84f07092 100644
--- a/src/onyxutils.c
+++ b/src/onyxutils.c
@@ -458,6 +458,9 @@ static PolySolveResult solve_poly_type(AstNode* target, AstType* type_expr, Type
                 bh_arr_push(elem_queue, ((PolySolveElem) {
                     .type_expr = (AstType*) ((AstArrayType *) elem.type_expr)->count_expr,
                     .kind = PSK_Value,
+
+                    // CLEANUP: Making an integer literal every time is very very very gross. This should
+                    // at least be cached or something.
                     .value = (AstTyped *) make_int_literal(context.ast_alloc, elem.actual->Array.count)
                 }));