From: Brendan Hansen <brendan.f.hansen@gmail.com>
Date: Fri, 26 Nov 2021 16:59:58 +0000 (-0600)
Subject: small speed up by making eh_shift_down iterative
X-Git-Url: https://git.brendanfh.com/?a=commitdiff_plain;h=5c69e7df3d85818fec8342d66f0e2fbb80af4345;p=onyx.git

small speed up by making eh_shift_down iterative
---

diff --git a/src/entities.c b/src/entities.c
index f489b356..3f707abe 100644
--- a/src/entities.c
+++ b/src/entities.c
@@ -42,26 +42,31 @@ static void eh_shift_up(EntityHeap* entities, i32 index) {
 }
 
 static void eh_shift_down(EntityHeap* entities, i32 index) {
-    i32 min_index = index;
+    while (1) {
+        i32 min_index = index;
 
-    i32 l = eh_lchild(index);
-    if (l < bh_arr_length(entities->entities)
-        && entity_compare(entities->entities[l], entities->entities[min_index]) < 0) {
-        min_index = l;
-    }
+        i32 l = eh_lchild(index);
+        if (l < bh_arr_length(entities->entities)
+            && entity_compare(entities->entities[l], entities->entities[min_index]) < 0) {
+            min_index = l;
+        }
 
-    i32 r = eh_rchild(index);
-    if (r < bh_arr_length(entities->entities)
-        && entity_compare(entities->entities[r], entities->entities[min_index]) < 0) {
-        min_index = r;
-    }
+        i32 r = eh_rchild(index);
+        if (r < bh_arr_length(entities->entities)
+            && entity_compare(entities->entities[r], entities->entities[min_index]) < 0) {
+            min_index = r;
+        }
 
-    if (index != min_index) {
-        Entity* tmp = entities->entities[min_index];
-        entities->entities[min_index] = entities->entities[index];
-        entities->entities[index] = tmp;
+        if (index != min_index) {
+            Entity* tmp = entities->entities[min_index];
+            entities->entities[min_index] = entities->entities[index];
+            entities->entities[index] = tmp;
+
+            index = min_index;
+            continue;
+        }
 
-        eh_shift_down(entities, min_index);
+        break;
     }
 }