From: David Phillips <dbphillipsnz@gmail.com>
Date: Thu, 10 Dec 2015 23:23:45 +0000 (+1300)
Subject: Change an eprintf to a die to stop child from running its own slideshow
X-Git-Url: https://git.brendanfh.com/?a=commitdiff_plain;h=022ae4836072e3534c5ce61d063179d6bab9d73a;p=sent.git

Change an eprintf to a die to stop child from running its own slideshow

The child thread was created because execlp will not return if successful.
The eprintf was placed after the call to execlp to catch any error, but the
child continued to return a (closed) fds[0], resulting in a second slideshow
being run by the child.

This commit fixes the issue by killing the child.
---

diff --git a/sent.c b/sent.c
index 99361e8..cdc637f 100644
--- a/sent.c
+++ b/sent.c
@@ -153,7 +153,7 @@ filter(int fd, const char *cmd)
 		close(fds[0]);
 		close(fds[1]);
 		execlp("sh", "sh", "-c", cmd, (char *)0);
-		eprintf("execlp sh -c '%s':", cmd);
+		die("execlp sh -c '%s':", cmd);
 	}
 	close(fds[1]);
 	return fds[0];